-
Notifications
You must be signed in to change notification settings - Fork 3k
Add session customization params to Runner options #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…etrieval from sessions and include new test.
seratch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this pull request! Adding the limit option is reasonable, but we'd like to make the new option to be open to future enhancement. So can you create new SessionSettings class (in the same way with ModelSettings) and move the liimt parameter as the first and only property in it?
…n, including default item retrieval limits.
…ed session management
…eval limits and add corresponding tests
…em retrieval limits and add corresponding tests
…al limits and add corresponding tests
…trieval limits and add corresponding tests
…trieval limits and add corresponding tests
…its and add corresponding tests
…or item retrieval limits and add corresponding tests
…pose the conversation ID with lazy initialization check.
Thanks for the feedback! I've refactored the implementation, following the same pattern as Changes made:
I believe this is extensible for future properties. For example, I'd like to add Let me know if it needs any adjustments |
…nd SessionSettings objects.
feat: Add
session_limitparameter to control conversation history retrieval from sessions and include new test.